[Offload] Fix APU detection for MI300 testing #143026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We have this check when the target is MI300 but it fails if this environment variable isn't set. Set a default value of '0' if not present so that will be converted to bool false.
|
@llvm/pr-subscribers-offload Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/143026.diff 1 Files Affected:
diff --git a/offload/test/lit.cfg b/offload/test/lit.cfg
index 0725b56f0f05d..df57be293138c 100644
--- a/offload/test/lit.cfg
+++ b/offload/test/lit.cfg
@@ -36,8 +36,7 @@ if 'HSA_ENABLE_SDMA' in os.environ:
# Architectures like gfx942 may or may not be APUs so an additional environment
# variable is required as some tests can be APU specific.
-if 'IS_APU' in os.environ:
- config.environment['IS_APU'] = os.environ['IS_APU']
+config.environment['IS_APU'] = os.environ.get('IS_APU', '0')
# set default environment variables for test
if 'CHECK_OPENMP_ENV' in os.environ:
|
carlobertolli
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have this check when the target is MI300 but it fails if this
environment variable isn't set. Set a default value of '0' if not
present so that will be converted to bool false.